Skip to content

[SDK] Update @mobile-wallet-protocol/client to 1.0.0 #6527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

[SDK] Update @mobile-wallet-protocol/client to 1.0.0 #6527

merged 1 commit into from
Mar 24, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 24, 2025

No description provided.

@vercel
Copy link

vercel bot commented Mar 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 6:55am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 6:55am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 6:55am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 6:55am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 6:55am

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c8f56b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@thirdweb-dev/react-native-adapter Patch
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 24, 2025
@joaquim-verges joaquim-verges changed the title Update @mobile-wallet-protocol/client to 1.0.0 [SDK] Update @mobile-wallet-protocol/client to 1.0.0 Mar 24, 2025
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Mar 24, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review March 24, 2025 06:40
@joaquim-verges joaquim-verges requested review from a team as code owners March 24, 2025 06:40
@socket-security
Copy link

socket-security bot commented Mar 24, 2025 •
edited
Loading

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@mobile-wallet-protocol/[email protected] ➜ 1.0.0 Transitive: environment, eval, filesystem, shell, unsafe +1232 209 MB cb-felix-z
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +444 148 MB react-native-bot

View full report↗︎

@joaquim-verges joaquim-verges force-pushed the Update_mobile-wallet-protocol/client_to_1.0.0 branch from 96daa76 to c8f56b1 Compare March 24, 2025 06:46
@joaquim-verges joaquim-verges mentioned this pull request Mar 24, 2025
Closed
@codecov
Copy link

codecov bot commented Mar 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.92%. Comparing base (d3f7884) to head (c8f56b1).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...s/thirdweb/src/wallets/coinbase/coinbase-mobile.ts 25.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6527      +/-   ##
==========================================
- Coverage   54.94%   54.92%   -0.02%     
==========================================
  Files         881      881              
  Lines       55159    55179      +20     
  Branches     3763     3767       +4     
==========================================
+ Hits        30305    30309       +4     
- Misses      24759    24775      +16     
  Partials       95       95
Flag Coverage Δ
packages 54.92% <25.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
...s/thirdweb/src/wallets/coinbase/coinbase-mobile.ts 37.34% <25.00%> (-2.43%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 111 ms (+276.93% 🔺) 1.1 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 129 ms (+49.54% 🔺) 2.7 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 43 ms (+1151.28% 🔺) 155 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 23 ms (+3109.44% 🔺) 33 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 93 ms (+960.16% 🔺) 480 ms

@joaquim-verges joaquim-verges merged commit 4f51201 into main Mar 24, 2025
32 of 33 checks passed
@joaquim-verges joaquim-verges deleted the Update_mobile-wallet-protocol/client_to_1.0.0 branch March 24, 2025 07:15
@joaquim-verges joaquim-verges mentioned this pull request Mar 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joaquim-verges joaquim-verges

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges